Let patch build on Cygwin on Windows 7

[jpflori]

The solution is simple:

• revert we should not build patch on Cygwin on Windows 7 #11232,
• install a manifest file.

Use spkg at
http://boxen.math.washington.edu/home/jpflori/patch-2.5.9.p3.spkg

CC: @kcrisman @dimpase

Component: porting: Cygwin

Keywords: spkg patch cygwin

Author: Jean-Pierre Flori

Reviewer: Dmitrii Pasechnik

Merged: sage-5.7.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13844

[jpflori]

comment:1

Spkg coming soon, builds and installs ok and patch seems functional on my Cygwin install.

[kcrisman]

comment:2

I assume this is so we can reduce the prereqs for Cygwin?

[kcrisman]

comment:3

Spkg coming soon, builds and installs ok and patch seems functional on my Cygwin install.

Spkg?

[jpflori]

comment:4

Replying to @kcrisman:

Spkg coming soon, builds and installs ok and patch seems functional on my Cygwin install.

Spkg?

Soon?

Seriously, I completely got out of the Cygwin stuff since christmas and just started dropping an eye recently on ATLAS and GCC/ECL.

I indeed have a (surely dirty) spkg on my home computer, but as it is surely dirty, I'll wait this week end to have a last look at it and won't scp it everywhere just now.

[kcrisman]

comment:5

Seriously, I completely got out of the Cygwin stuff since christmas and just started dropping an eye recently on ATLAS and GCC/ECL.

Fair enough, I wouldn't have asked (since I have patch installed on my Cygwin) except I saw your reappearance.

I indeed have a (surely dirty) spkg on my home computer, but as it is surely dirty, I'll wait this week end to have a last look at it and won't scp it everywhere just now.

I don't think it's necessary yet in any case, since we can first require it, then drop that requirement.

[jpflori]

comment:6

New spkg at
http://boxen.math.washington.edu/home/jpflori/patch-2.5.9.p3.spkg

[jpflori]

Author: Jean-Pierre Flori

[kcrisman]

comment:8

Diff looks good, except I don't know about the manifest. I may get a chance to try this Monday, otherwise it will have to wait a few weeks. So partial positive review.

[jpflori]

comment:9

New spkg, wrong year in the previous one...

[jdemeyer]

comment:10

Please quote $SAGE_LOCAL:

    cp ../patch.exe.manifest "$SAGE_LOCAL/bin/"

[jpflori]

Attachment: patch-2.5.9.p3.diff.gz

Spkg diff, for review only.

[jpflori]

comment:11

Done, spkg and diff updated.

[kcrisman]

comment:12

This does successfully install on my Cygwin as well. How can I check that this was the patch actually used (as opposed to the patch on my system)? The diff looks fine.

[jpflori]

comment:13

You could just run 'which patch' inside a Sage shell and check it points to the Sage installed one.

[kcrisman]

comment:14

Sadly, after a required BLODA upgrade to allow my internet access with this machine, Sage won't build - nothing reliable, just the usual horrible stuff and rebasing just delays the pain. Python package in particular is affected. So I wonder whether we should just do this and assume it works on XP. Sorry.

[jpflori]

comment:15

Maybe Dima can have a look?

On XP the manifest files are not needed, so the only change is that patch is now actually installed (that's the revert #11232 part).

[dimpase]

comment:16

OK, it works.

[jdemeyer]

Reviewer: Dmitrii Pasechnik

[jdemeyer]

Merged: sage-5.7.beta2