Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of virtual Klebers algorithm #13838

Closed
tscrim opened this issue Dec 17, 2012 · 19 comments
Closed

Implementation of virtual Klebers algorithm #13838

tscrim opened this issue Dec 17, 2012 · 19 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Dec 17, 2012

The current implementation of KleberTree is only valid for the simply laced types. This ticket will implement the virtual Kleber algorithm and thus expand KleberTree to generate rigged configurations for all affine types.

Apply: attachment: trac_13838-virtual_kleber_alg-ts.patch

Depends on #13871
Depends on #14469

CC: @sagetrac-sage-combinat @anneschilling

Component: combinatorics

Keywords: rigged configurations

Author: Travis Scrimshaw

Reviewer: Anne Schilling

Merged: sage-5.13.beta0

Issue created by migration from https://trac.sagemath.org/ticket/13838

@tscrim tscrim added this to the sage-5.11 milestone Dec 17, 2012
@tscrim tscrim self-assigned this Dec 17, 2012
@tscrim
Copy link
Collaborator Author

tscrim commented Dec 28, 2012

Dependencies: #13871

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 25, 2013

comment:4

Attachment: trac_13871-virtual_cartan_type-ts.patch.gz

Since I attached the wrong patch...

For patchbot:

Apply only: trac_13838-virtual_kleber_alg-ts.patch

@tscrim
Copy link
Collaborator Author

tscrim commented Jul 9, 2013

comment:5

New version based over the changes in #13871.

For patchbot:

Apply: trac_13838-virtual_kleber_alg-ts.patch

@tscrim
Copy link
Collaborator Author

tscrim commented Jul 9, 2013

comment:6

Removed workaround of #14870 because it is now part of #13871.

For patchbot:

Apply: trac_13838-virtual_kleber_alg-ts.patch

@tscrim
Copy link
Collaborator Author

tscrim commented Jul 13, 2013

comment:7

New version with (trivial) rebase over #14469.

For patchbot:

Apply: trac_13838-virtual_kleber_alg-ts.patch

@tscrim
Copy link
Collaborator Author

tscrim commented Jul 13, 2013

Changed dependencies from #13871 to #13871 #14469

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@tscrim
Copy link
Collaborator Author

tscrim commented Aug 30, 2013

comment:9

New version over changes in #13871.

For patchbot:

Apply: trac_13838-virtual_kleber_alg-ts.patch

@fchapoton
Copy link
Contributor

comment:10

Hello,

  • there is a small typo "Kleber tree clases"
  • maybe you can use the :arxiv: role in the references ?

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 10, 2013

comment:11

With added arXiv role, fixed the typo, and bringing the doc up to new specs. Thanks for having a look at this Frederic.

For patchbot:

Apply: trac_13838-virtual_kleber_alg-ts.patch

@anneschilling
Copy link
Contributor

comment:12

Hi Travis,

It would be good if you could implement the tensor product multiplicity (and please call it tensor_product_multiplicity) which is formula (3.2) of http://arxiv.org/pdf/math/9809087.pdf in order to check that the code is giving the correct output. For nonsimply-laced types it would be the virtual analogue of this formula. The Kleber tree gives the admissible partitions, but to get the multiplicity one needs to sum over the product of binomial coefficients.

Also, I think it would be better to access the VirtualKleberTree through its own class (rather than through KleberTree). It is fine to inherit from KleberTree, but the construction is mathematically inherently different. For example for type C_n^{(1)} the construction is via the A_{2n-1}^{(1)} Kleber tree and type A weights, rather than type C weights. Since this is mostly just used in later code on rigged configuration, I think it won't be necessary to export VirtualKleberTree into the namespace.

Thanks for your work on this!

Anne

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 18, 2013

comment:13

Hey Anne,

Here's the new version with the changes we've discussed (via e-mail/in person) along with a method latex_options() for controlling the latex output. I also think it's okay for the virtual Kleber tree to accept simply-laced types as input and for them to not compare as equal (since they are different mathematical constructions because we consider it as a folded type). I've documented this behavior.

Thank you for doing the review,

Travis

For patchbot:

Apply: trac_13838-virtual_kleber_alg-ts.patch

@anneschilling
Copy link
Contributor

comment:14

Hi Travis,

If you want to allow for simply-laced input in the VirtualKleberTree, don't you want to select all nodes and bracket them in the output? Otherwise the behavior is different from the simply-laced and non-simply-laced types. If it is really just the same as the usual KleberTree, then why not make them equal in this case?

Best,

Anne

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 18, 2013

New version

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 18, 2013

comment:15

Attachment: trac_13838-virtual_kleber_alg-ts.patch.gz

Hey Anne,

I made it raise an error on simply-laced types.

Best,

Travis

For patchbot:

Apply: trac_13838-virtual_kleber_alg-ts.patch

@anneschilling
Copy link
Contributor

comment:16

Hi Travis,

Looks good now (you want to add a test for the simply-laced types in the VirtualKleberTree for completeness).

Anne

@anneschilling
Copy link
Contributor

Changed keywords from none to rigged configurations

@anneschilling
Copy link
Contributor

Reviewer: Anne Schilling

@jdemeyer
Copy link
Contributor

jdemeyer commented Oct 2, 2013

Merged: sage-5.13.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants