-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of the class ClusterSeed #13369
Comments
comment:2
This was done because trac_13369-cluster_seed-cs.patch no longer applies after recent changes to 10538, although it really was only this four line conflict.
trac_13369-cluster_seed-cs-NEW.patch followed by trac_13369-cluster_seed-gm.patch, and then the rebuilt sage passes all doc tests and appears to work correctly.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:5
Replying to @sagetrac-gmoose05: I just renamed and uploaded the two relevant patches without any changes. |
comment:6
Also, despite the patchbot's inability to apply the patches, it works fine with 5.3.rc1 on my machine (with the 10527 and 10538 patches applied first). |
comment:7
Both patches rebased according to the new lazy import. No other changes. |
Reviewer: Salvatore Stella |
comment:9
Hi, I updated my first patch (and uploaded Gregg's patch without changes). This resulted in some missing doctests which I then added in yet another patch. We also had some old things in the ClusterVariable class which I removed. If we need that back later, we can do it in another ticket... Cheers, Christian |
Changed author from Christian Stump to Christian Stump, Gregg Musiker |
This comment has been minimized.
This comment has been minimized.
Attachment: trac_13369_cluster_seed.patch.gz |
This comment has been minimized.
This comment has been minimized.
Attachment: trac_13369-review.patch.gz |
comment:12
Attachment: trac_13369-second_review.patch.gz |
Changed keywords from cluster algebra, quiver to cluster algebra, quiver, days45 |
Merged: sage-5.8.beta0 |
This class implements cluster seeds for skew-symmetrizable matrices.
The patch contains multiple examples.
Depends on #10538
Component: combinatorics
Keywords: cluster algebra, quiver, days45
Author: Christian Stump, Gregg Musiker
Reviewer: Salvatore Stella
Merged: sage-5.8.beta0
Issue created by migration from https://trac.sagemath.org/ticket/13369
The text was updated successfully, but these errors were encountered: