Update Givaro to 3.7.1

[vbraun]

With Givaro 3.7.0, the test-crt in the Givaro test suite fails on SPARC with the following backtrace:

-bash-3.00$ /home/vbraun/opt/mark/gdb-7.4.1/gdb/gdb test-crt
GNU gdb (GDB) 7.4.1
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "sparc-sun-solaris2.10".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from
/home/vbraun/opt/mark/sage-5.1.beta3/spkg/build/givaro-3.7.0/src/tests/test-crt...done.
(gdb) run
Starting program:
/home/vbraun/opt/mark/sage-5.1.beta3/spkg/build/givaro-3.7.0/src/tests/test-crt
[Thread debugging using libthread_db enabled]
[New Thread 1 (LWP 1)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1 (LWP 1)]
0x00029030 in Givaro::GFqDom<long>::GFqDom (this=0x7eaec, F=...)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givgfq.h:100
100                     _dcharacteristic = F._dcharacteristic;
(gdb) bt
#0  0x00029030 in Givaro::GFqDom<long>::GFqDom (this=0x7eaec, F=...)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givgfq.h:100
#1  0x00033c3c in Givaro::GivaroMM<Givaro::GFqDom<long> >::initone
(p=0x7eaec, V=...)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givaromm.h:297
#2  0x00031110 in Givaro::GivaroMM<Givaro::GFqDom<long> >::initialize
(bloc=0x7eaec, s=15, V=...)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givaromm.h:300
#3  0x000268f8 in Givaro::Array0<Givaro::GFqDom<long> >::build
(this=0xffbff890, s=15, t=...)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givarray0.inl:30
#4  0x00021ad0 in Givaro::Array0<Givaro::GFqDom<long> >::Array0
(this=0xffbff890, s=15)
   at /home/vbraun/opt/mark/sage-5.1.beta3/local//include/givaro/givarray0.inl:39
#5  0x0001bf04 in tmain<Givaro::GFqDom<long> > (argc=1,
argv=0xffbffb3c, generator=...) at test-crt.C:49
#6  0x00013d00 in main (argc=1, argv=0xffbffb3c) at test-crt.C:151
(gdb) l
95              {
96                      zero = F.zero;
97                      one = F.one;
98                      mOne = F.mOne;
99                      _characteristic = F._characteristic;
100                     _dcharacteristic = F._dcharacteristic;
101                     _exponent = F._exponent;
102                     _irred = F._irred;
103                     _q = F._q;
104                     _qm1 = F._qm1;

This is related to placement new in the Givaro array class, which we do not use in Sage at this point. Nevertheless it would be nice to clean this up eventually.

Updating Givaro to 3.7.1 fixes the problem.
Use spkg at http://perso.telecom-paristech.fr/~flori/sage/givaro-3.7.1.spkg

Depends on #12840
Depends on #12841
Depends on #12883

Dependencies: #12840, #12841, to be merged with #12883

Upstream: Fixed upstream, in a later stable release.

CC: @jpflori

Component: finite rings

Keywords: SPARC givaro bus error spkg

Author: Paulo César Pereira de Andrade, Martin Albrecht, Jean-Pierre Flori

Reviewer: Volker Braun

Merged: sage-5.4.beta1

Issue created by migration from https://trac.sagemath.org/ticket/13164

[vbraun]

comment:1

This will be fixed in Givaro-3.7.1, which is scheduled to appear in July 2012.

[vbraun]

Changed upstream from Reported upstream. Developers acknowledge bug. to Fixed upstream, in a later stable release.

[jpflori]

comment:2

givaro 3.7.1 was released on 11/07/2012.

[jpflori]

comment:3

I've packaged an updated spkg (just updating the src dir, no problems on linux) at
http://perso.telecom-paristech.fr/~flori/sage/givaro-3.7.1.spkg

No changes committed in yet (all in a queue patch).

[vbraun]

comment:4

I'll review it if you commit your changes.

[jpflori]

Attachment: givaro-3.7.1.diff.gz

Spkg diff, for review only. Committed in spkg.

[jpflori]

Changed keywords from SPARC givaro bus error to SPARC givaro bus error spkg

[jpflori]

comment:5

SPKG reuploaded with committed changes.
I did not have the time to run make ptest on Linux x86_64, and even less on SPARC hardware.

[jpflori]

Author: Jean-Pierre Flori

[jpflori]

Dependencies: #9511

[jpflori]

comment:7

make ptest passes on Ubuntu 12.04 on x86_64.

[vbraun]

comment:8

Fixes the testsuite bug on SPARC. Only minor changes wrt. 3.7.0. Tests fine on x86_64. LGTM

[vbraun]

Attachment: trac_9511_givaro_3_7_x.patch.gz

Patch from #9511

[vbraun]

Reviewer: Volker Braun

[vbraun]

Changed dependencies from #9511 to #12840, #12841, to be merged with #12883

[jdemeyer]

Changed author from Jean-Pierre Flori to Paulo César Pereira de Andrade, Martin Albrecht, Jean-Pierre Flori

[jdemeyer]

Merged: sage-5.4.beta1