Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to python-2.7.3 #13013

Closed
vbraun opened this issue May 25, 2012 · 18 comments
Closed

Update to python-2.7.3 #13013

vbraun opened this issue May 25, 2012 · 18 comments

Comments

@vbraun
Copy link
Member

vbraun commented May 25, 2012

Python 2.7.2 distutils have a bug on ext4 or other filesystems with sub-second resolution. The result is that some source files are copied unnecessarily. This is somewhat annoying in sage -b.

New spkg at http://boxen.math.washington.edu/home/jdemeyer/spkg/python-2.7.3.p0.spkg

Apply attachment: trac_13013_setup_deps.patch

CC: @kiwifb @novoselt

Component: packages: standard

Keywords: sd40.5

Author: Volker Braun

Reviewer: Jeroen Demeyer

Merged: sage-5.0.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/13013

@vbraun vbraun added this to the sage-5.1 milestone May 25, 2012
@vbraun
Copy link
Member Author

vbraun commented May 25, 2012

comment:2

Our setup.py needed some fixes to work with the new python, most notably you need to tell it to have at least one thread. Also fixed some other warts that annoyed me, like the

setup.py:644: UserWarning: could not find dependency <vector> included in /home/vbraun/opt/sage-5.0/local/lib/python/site-packages/Cython/Includes/libcpp/vector.pxd. I will assume it is a system C/C++ header.

@vbraun

This comment has been minimized.

@vbraun

This comment has been minimized.

@vbraun
Copy link
Member Author

vbraun commented May 25, 2012

spkg diff for review purposes only

@kiwifb
Copy link
Member

kiwifb commented May 25, 2012

comment:4

Attachment: python-spkg.diff.gz

I think one doctest may need fixing, I don't have the particular at hand because my work computer is switched off.

@novoselt
Copy link
Member

comment:5

I am getting

sage -t -long devel/sage-main/sage/misc/prandom.py
**********************************************************************
File "/tmp/sage-5.0/devel/sage-main/sage/misc/prandom.py", line 211:
    sage: [expovariate(0.001) for i in range(3)]
Expected:
    [2194.27528710212, 664.856145830767, 3108.01255906546]
Got:
    [118.152309288166, 722.261959038118, 45.7190543690470]
**********************************************************************
File "/tmp/sage-5.0/devel/sage-main/sage/misc/prandom.py", line 213:
    sage: [expovariate(1.0) for i in range(3)]
Expected:
    [1.10114367058632, 0.652772818610748, 1.69983589896220]
Got:
    [0.404201816061304, 0.735220464997051, 0.201765578600627]
**********************************************************************
File "/tmp/sage-5.0/devel/sage-main/sage/misc/prandom.py", line 215:
    sage: [expovariate(1000) for i in range(3)]
Expected:
    [0.0003554358393809391, 0.0025254102812587195, 0.0001175899408167489]
Got:
    [0.0012068700332283973, 8.340929747302108e-05, 0.00219877067980605]
**********************************************************************
1 items had failures:
   3 of   6 in __main__.example_11
***Test Failed*** 3 failures.

@vbraun
Copy link
Member Author

vbraun commented May 26, 2012

Changed keywords from none to sd40.5

@kiwifb
Copy link
Member

kiwifb commented May 26, 2012

comment:7

That's the one I got in sage-on-gentoo when we did move to 2.7.3. I think that's the exact same value but that's a memory from 3 weeks ago. We also need to check if it is platform dependent.

@vbraun
Copy link
Member Author

vbraun commented May 26, 2012

comment:8

This is the upstream change http://hg.python.org/releasing/2.7.3/rev/4970fa3c4a0b

On the plus side, its as platform-independent as it was before.

@vbraun
Copy link
Member Author

vbraun commented May 26, 2012

Attachment: trac_13013_setup_deps.patch.gz

Updated patch

@vbraun
Copy link
Member Author

vbraun commented May 26, 2012

comment:9

All doctests pass now...

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

comment:10

I'll have a look.

@jdemeyer
Copy link

comment:11

Looks good to me. The package works and the changes to setup.py make sense.

@jdemeyer
Copy link

comment:13

Many files in src/ are not world-readable. This should be fixed to be safe.

@jdemeyer
Copy link

comment:14

Permissions fixed.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

Merged: sage-5.0.1.rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants