Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopgap for 12509 #12692

Closed
roed314 opened this issue Mar 18, 2012 · 16 comments
Closed

Stopgap for 12509 #12692

roed314 opened this issue Mar 18, 2012 · 16 comments
Assignees
@williamstein
Labels
c: number theory p: blocker / 1 t: bug
Milestone
sage-5.0

Comments

@roed314
Copy link
Contributor

roed314 commented Mar 18, 2012

Depends on #12691

Component: number theory

Keywords: rd2

Author: David Roe, Jennifer Balakrishnan

Reviewer: R. Andrew Ohana

Merged: sage-5.0.beta11

Issue created by migration from https://trac.sagemath.org/ticket/12692
@roed314 roed314 added this to the sage-5.0 milestone Mar 18, 2012
@roed314
Copy link
Contributor Author

roed314 commented Mar 19, 2012

Dependencies: #12691

@jbalakrishnan
Copy link

comment:2

Looks good.

@jbalakrishnan
Copy link

Changed keywords from none to rd2

@ohanar

This comment has been minimized.

Sign in to view
@ohanar
Copy link
Member

ohanar commented Mar 20, 2012

Reviewer: R. Andrew Ohana, Jen Balakrishnan

@ohanar
Copy link
Member

ohanar commented Mar 20, 2012

Author: David Roe

@jbalakrishnan
Copy link

comment:5

This patch (12692.2.patch) imports from sage.misc.stopgap.

@ohanar
Copy link
Member

ohanar commented Mar 22, 2012

Changed reviewer from R. Andrew Ohana, Jen Balakrishnan to R. Andrew Ohana

@ohanar
Copy link
Member

ohanar commented Mar 22, 2012

Changed author from David Roe to David Roe, Jennifer Balakrishnan

@ohanar
Copy link
Member

ohanar commented Mar 22, 2012

comment:6

Looks good.

@jdemeyer
Copy link

comment:7

Could you write a proper commit message? "Trac 12692" isn't. You should (briefly) describe what the patch does. There is no need to write the ticket number.

@jbalakrishnan
Copy link

comment:8

12692.2.2.patch has a more descriptive commit message.

@jdemeyer
Copy link

Attachment: 12692.patch.gz

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link

comment:9

Wrapped the commit message over 3 lines (commit messages should not be one long line. If you wrap commit messages, make sure the first line, which appears in hg log, makes sense by itself).

@jdemeyer
Copy link

Merged: sage-5.0.beta11

@williamstein williamstein mentioned this issue May 13, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: number theory p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-5.0
Development

No branches or pull requests
5 participants
@roed314 @williamstein @ohanar @jbalakrishnan @jdemeyer