Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M4RIE test suite fails due to missing dependencies #12245

Closed
loefflerd mannequin opened this issue Jan 2, 2012 · 19 comments
Closed

M4RIE test suite fails due to missing dependencies #12245

loefflerd mannequin opened this issue Jan 2, 2012 · 19 comments

Comments

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jan 2, 2012

The M4RIE (cf. #9562) test script has dependencies on some libraries which are not made explicit in spkg/standard/deps or SPKG.txt. These include (at least) Givaro, NTL and GMP/MPIR. Since the Sage build script doesn't know about these dependencies, this means that building Sage in parallel with SAGE_CHECK=yes can fail.

Apply attachment: trac12245_m4rie_fix_deps.2.patch to Sage root repository.

Install http://sage.math.washington.edu/home/malb/spkgs/libm4rie-20111004.p1.spkg

Upstream: None of the above - read trac for reasoning.

CC: @malb

Component: packages: standard

Keywords: m4rie

Author: Martin Albrecht, David Loeffler

Reviewer: Martin Albrecht, David Loeffler

Merged: sage-4.8.rc0

Issue created by migration from https://trac.sagemath.org/ticket/12245

@loefflerd loefflerd mannequin added this to the sage-4.8 milestone Jan 2, 2012
@malb

This comment has been minimized.

@malb
Copy link
Member

malb commented Jan 2, 2012

Attachment: trac12245_m4rie_fix_deps.patch.gz

@malb
Copy link
Member

malb commented Jan 2, 2012

comment:2

the attached patch should fix the issue but I haven't tested it.

@malb

This comment has been minimized.

@malb
Copy link
Member

malb commented Jan 2, 2012

Upstream: None of the above - read trac for reasoning.

@malb
Copy link
Member

malb commented Jan 2, 2012

Author: Martin Albrecht

@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented Jan 2, 2012

comment:3

Should we not change SPKG.txt to match?

@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented Jan 2, 2012

comment:4

Patch does not apply (conflicts with #12016)

@loefflerd loefflerd mannequin added s: needs work and removed s: needs review labels Jan 2, 2012
@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented Jan 2, 2012

Attachment: trac12245_m4rie_fix_deps.2.patch.gz

sage root repo -- apply only this patch

@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented Jan 2, 2012

comment:5

Here's an essentially equivalent patch which will apply to versions from 4.8.alpha5 onwards. But we should still fix the spkg.txt file.

@malb
Copy link
Member

malb commented Jan 2, 2012

comment:6

Ah, thanks. I was in the process of building alpha5. I'll provide an updated SPKG with an updated SPKG.txt.

@malb

This comment has been minimized.

@malb
Copy link
Member

malb commented Jan 2, 2012

@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented Jan 2, 2012

comment:8

I'm happy with the changes to SPKG.txt, so if you are happy with the deps patch, everybody's happy :-)

@loefflerd loefflerd mannequin added s: needs review and removed s: needs work labels Jan 2, 2012
@loefflerd
Copy link
Mannequin Author

loefflerd mannequin commented Jan 2, 2012

Changed author from Martin Albrecht to Martin Albrecht, David Loeffler

@malb
Copy link
Member

malb commented Jan 2, 2012

Reviewer: Martin Albrecht, David Loeffler

@malb
Copy link
Member

malb commented Jan 2, 2012

comment:10

Everybody happy

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Jan 3, 2012

Merged: sage-4.8.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants