Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all element classes should take the parent as first mandatory argument. #11931

Closed
nthiery opened this issue Oct 17, 2011 · 4 comments
Closed

Comments

@nthiery
Copy link
Contributor

nthiery commented Oct 17, 2011

Taken from Sets.ParentMethods._element_constructor_from_element_class:

            Caveat: ``self`` is passed to the constructor of the
            element class as a keyword argument ``parent``. Many
            element classes in Sage, in particular those implemented
            by mean of extension types, take ``parent`` as first
            mandatory argument instead.

            This incompatibility will be fixed soon (Fall 2009?) by
            having all element classes take ``parent`` as first
            mandatory argument, and updating this default
            implementation of :meth:`_element_constructor_`.

Fall 2009 is long over ...

CC: @sagetrac-sage-combinat

Component: categories

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/11931

@nthiery nthiery added this to the sage-4.8 milestone Oct 17, 2011
@nthiery nthiery self-assigned this Oct 17, 2011
@jdemeyer
Copy link

jdemeyer commented Nov 3, 2011

Milestone sage-4.7.3 deleted

@jdemeyer jdemeyer removed this from the sage-4.8 milestone Nov 3, 2011
@tscrim
Copy link
Collaborator

tscrim commented Jun 27, 2013

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 27, 2013

comment:2

This was taken care of in #14519.

@mwhansen
Copy link
Contributor

comment:3

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants