Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve class_graph #11108

Closed
nthiery opened this issue Apr 1, 2011 · 9 comments
Closed

Improve class_graph #11108

nthiery opened this issue Apr 1, 2011 · 9 comments
Assignees
@jasongrout
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-4.7.1

Comments

@nthiery
Copy link
Contributor

nthiery commented Apr 1, 2011

Improvements to class_graph:

  • Returns directly a DiGraph by default
  • Supports a class or an object as input
  • Improves the doc

Apply :

  • trac_11108-classgraph-nt.patch

CC: @nathanncohen @sagetrac-sage-combinat

Component: misc

Keywords: class, inheritance

Author: Nicolas M. Thiéry

Reviewer: Nathann Cohen

Merged: sage-4.7.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/11108
@nthiery nthiery added this to the sage-4.7 milestone Apr 1, 2011
@nthiery

This comment has been minimized.

Sign in to view
@nathanncohen

This comment has been minimized.

Sign in to view
@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 4, 2011

comment:3

Attachment: trac_11108-review.patch.gz

Hello !!!

Here is a small patch adding 3 lines of comments to your code, so that other will understand it faster than I did :-)

If that's fine with you, you can set the ticket to "positive review" !

Nathann

@nthiery
Copy link
Contributor Author

nthiery commented Apr 4, 2011

Attachment: trac_11108-classgraph-nt.patch.gz

Final patch with Nathann's review

@nthiery
Copy link
Contributor Author

nthiery commented Apr 4, 2011

comment:4

Hi Nathann,

Thanks for your review! The comments were welcome indeed :-)
I rephrased them just a bit, and folded your patch into yours.

No comment on sage-devel, so I guess noone cares.

Cheers,
Nicolas

@nthiery

This comment has been minimized.

Sign in to view
@nthiery
Copy link
Contributor Author

nthiery commented Apr 4, 2011

Reviewer: Nathann Cohen

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 5, 2011

comment:5

Great ! This one's good to go ! I wanted to check the documentation again but Sage does not like to have some file added in a branch that disappear in another :-)

Nathann

@jdemeyer jdemeyer modified the milestones: sage-4.7, sage-4.7.1 Apr 13, 2011
@jdemeyer
Copy link

Merged: sage-4.7.1.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongrout jasongrout

Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-4.7.1
Development

No branches or pull requests
3 participants
@jasongrout @nthiery @jdemeyer