Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the SubwordComplex as defined by Knutson and Miller #11010

Closed
stumpc5 opened this issue Mar 24, 2011 · 114 comments
Closed

Implementation of the SubwordComplex as defined by Knutson and Miller #11010

stumpc5 opened this issue Mar 24, 2011 · 114 comments

Comments

@stumpc5
Copy link
Contributor

stumpc5 commented Mar 24, 2011

This patch provides an implementation of the subword complex:

Fix a Coxeter system (W,S). Let Q = be a finite word in S and pi in W.

The subword complex Delta(Q,pi) is then defined to be the simplicial complex with vertices being {0,...,n-1}, (n = len(Q), one vertex for each letter in Q) and with facets given by all (indices of) subwords Q' of Q for which Q\Q' is a reduced expression for pi.

    sage: W = CoxeterGroup(['A',2],index_set=[1,2])
    sage: w = W.from_reduced_word([1,2,1])
    sage: C = SubwordComplex([2,1,2,1,2],w); C
    Subword complex of type ['A', 2] for Q = [2, 1, 2, 1, 2] and pi = 121
    sage: C.facets()
    {(1, 2), (3, 4), (0, 4), (2, 3), (0, 1)}

Component: combinatorics

Keywords: subword complex, simplicial complex

Author: Christian Stump

Branch/Commit: 17518c1

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/11010

@stumpc5
Copy link
Contributor Author

stumpc5 commented Apr 4, 2011

Author: Christian Stump

@stumpc5

This comment has been minimized.

@stumpc5
Copy link
Contributor Author

stumpc5 commented Apr 4, 2011

Changed keywords from none to subword complex, simplicial complex

@stumpc5

This comment has been minimized.

@stumpc5
Copy link
Contributor Author

stumpc5 commented Jun 8, 2011

Dependencies: 11187, 11122

@stumpc5
Copy link
Contributor Author

stumpc5 commented Jun 11, 2011

Changed dependencies from 11187, 11122 to #11187, #11122

@stumpc5 stumpc5 added this to the sage-4.7.2 milestone Jun 11, 2011
@stumpc5
Copy link
Contributor Author

stumpc5 commented Oct 8, 2011

Changed dependencies from #11187, #11122 to #11122

@fchapoton
Copy link
Contributor

Changed dependencies from #11122 to #12774

@stumpc5
Copy link
Contributor Author

stumpc5 commented Nov 20, 2012

comment:7

Replying to @fchapoton:

Okay, I must confess that I tend to not finish implementations once the patch does what I want it to do...

The dependencies of this patch must (unfortunately) inherit as well the dependencies of #11122. This is to say that this patch actually relies on many things implemented in #11187.

I would be very, very glad if anyone would finally start reviewing the universal cyclotomic field, #8327 on which #11187 depends (I would first need to rebase it, and make sure that the trac version is updated to the newest version on the combinat queue).

Cheers, Christian

@stumpc5
Copy link
Contributor Author

stumpc5 commented Nov 20, 2012

Changed dependencies from #12774 to #11187, #12774

@stumpc5
Copy link
Contributor Author

stumpc5 commented Jan 23, 2013

Attachment: trac_11010-subword_complex-cs.patch.gz

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@fchapoton
Copy link
Contributor

Branch: u/chapoton/11010

@fchapoton
Copy link
Contributor

comment:10

I have made a git branch. It does not work: runs into an infinite recursion because of #15456.


New commits:

3b8df81trac_11010-subword_complex-cs.patch
a525fdctrac #11010 code clean-up

@fchapoton
Copy link
Contributor

Commit: a525fdc

@fchapoton
Copy link
Contributor

comment:11

The code needs to be 100% doctested. Some empty methods should be removed.

@fchapoton
Copy link
Contributor

Work Issues: coverage

@fchapoton
Copy link
Contributor

Changed dependencies from #11187, #12774 to #11187, #12774, #15456

@tscrim
Copy link
Collaborator

tscrim commented Jan 3, 2016

comment:70

Does the plotting also work for type C, being that it is the dual of type B (and we are dealing with Cartan types)?

@stumpc5
Copy link
Contributor Author

stumpc5 commented Jan 4, 2016

comment:71

I am rather confused now:

  • First Sage start
sage: W = CoxeterGroup(['B',4])
sage: W.coxeter_matrix().coxeter_type()
Coxeter type of ['B', 4]
sage: W = CoxeterGroup(['C',4])
sage: W.coxeter_matrix().coxeter_type()
Coxeter type of ['B', 4]
  • Second Sage start
sage: W = CoxeterGroup(['C',4])
sage: W.coxeter_matrix().coxeter_type()
Coxeter type of ['C', 4]
sage: W = CoxeterGroup(['B',4])
sage: W.coxeter_matrix().coxeter_type()
Coxeter type of ['C', 4]

In particular, the root systems W.roots() are not correct in the two second calls of CoxeterGroup.

Also, the plotting now assumes that the first index is the type B/C special one. This is, it is expected that

sage: s0 = W.simple_reflection(W.index-set()[0])
sage: s1 = W.simple_reflection(W.index-set()[1])
sage: (s0*s1).order()
4

I doubt that this is correct in the current implementation of Coxeter groups where the last index is expected to be special. If so, I will add some magic to figure out the proper labelling...

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2016

comment:72

The first issue is the result of my quick hacking to get something working. The Coxeter matrices are equal for the Cartan types B and C, and the Coxeter matrix is the information passed to the UniqueRepresentation cache. There are a number of ways to go moving forward, but I think that deserves its own separate ticket.

For the second issue, yes, you are correct. The n-1 and n nodes have the order 4 relation between them, as this agrees with the corresponding B/C Cartan types (and the Coxeter matrix). You are welcome to relabel the Coxeter type, which should work, or go to the Coxeter graph and find the edge label4ed by 4 and use those nodes. Personally, I would use the latter option since it is independent of the labeling.

@stumpc5
Copy link
Contributor Author

stumpc5 commented Jan 4, 2016

comment:73

I also have the problem that the plot only allows irreducible types. When playing with reducible types, I got to the types B vs. G bug in #19830...

@stumpc5
Copy link
Contributor Author

stumpc5 commented Jan 4, 2016

Changed branch from u/chapoton/11010 to u/stumpc5/11010

@fchapoton
Copy link
Contributor

comment:76

Is this "needs_review" ?


New commits:

4864a64Merge branch '11010-new' into u/stumpc5/11010-new
7722489Merge branch 'u/chapoton/11010' of git://trac.sagemath.org/sage into u/stumpc5/11010-new
839b2e2fixing the index set for the plot

@fchapoton
Copy link
Contributor

Changed commit from 1b10c95 to 839b2e2

@stumpc5
Copy link
Contributor Author

stumpc5 commented Jan 4, 2016

comment:77

Is this "needs_review" ?

Not quite, I wanted to add a few more doctests for the type B plotting with various indexing sets. But then saw that the indexing in CoxeterGroup is corrupted, see #19830. This is another issue, but I still want to add more examples/testing.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 5, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

0f90c26fixed another b/c bug + some cosmetics to the code

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 5, 2016

Changed commit from 839b2e2 to 0f90c26

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 5, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

e8e160cfixed a docstring and adding one more test

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 5, 2016

Changed commit from 0f90c26 to e8e160c

@fchapoton
Copy link
Contributor

Changed commit from e8e160c to 17518c1

@fchapoton
Copy link
Contributor

comment:81

ok, good enough for me.

I have made two minor doc changes, and now set this again to positive review.

Any further changes will have to be in another ticket.


New commits:

17518c1trac #11010 two details

@fchapoton
Copy link
Contributor

Changed branch from u/stumpc5/11010 to u/chapoton/11010

@vbraun
Copy link
Member

vbraun commented Jan 6, 2016

Changed branch from u/chapoton/11010 to 17518c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants