From 434071a5f28bd8ec8b57dfb52a7d3302a598164f Mon Sep 17 00:00:00 2001 From: "Trevor K. Karn" Date: Thu, 11 Aug 2022 12:14:15 -0700 Subject: [PATCH 1/2] Rewrite loop computing outside corners --- src/sage/combinat/partition.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/sage/combinat/partition.py b/src/sage/combinat/partition.py index 811679ede16..f8001a3476c 100644 --- a/src/sage/combinat/partition.py +++ b/src/sage/combinat/partition.py @@ -4030,12 +4030,9 @@ def outside_corners(self): p = self if p.is_empty(): return [(0,0)] - res = [ (0, p[0]) ] - for i in range(1, len(p)): - if p[i-1] != p[i]: - res.append((i,p[i])) + res = [(0, p[0])] + res.extend((n, j) for n, (i, j) in enumerate(zip(p[:-1], p[1:]), start=1) if i != j) res.append((len(p), 0)) - return res addable_cells = outside_corners # for compatibility with partition tuples From bde6bb5e919836e7d7412288d51d78833f1976f6 Mon Sep 17 00:00:00 2001 From: "Trevor K. Karn" Date: Fri, 12 Aug 2022 10:33:41 -0700 Subject: [PATCH 2/2] Change to list --- src/sage/combinat/partition.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sage/combinat/partition.py b/src/sage/combinat/partition.py index f8001a3476c..f3d7b7f19bc 100644 --- a/src/sage/combinat/partition.py +++ b/src/sage/combinat/partition.py @@ -4027,8 +4027,8 @@ def outside_corners(self): sage: Partition([]).outside_corners() [(0, 0)] """ - p = self - if p.is_empty(): + p = self._list + if not p: return [(0,0)] res = [(0, p[0])] res.extend((n, j) for n, (i, j) in enumerate(zip(p[:-1], p[1:]), start=1) if i != j)