Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set $data._value in updateValue if reduce option is set, it is… #1210

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

schelmo
Copy link
Contributor

@schelmo schelmo commented Jun 13, 2020

… set by the watcher of value

if the parent denies to set an option, vue-select will still have the value stored (setted in updateValue()).
i also extended the v-model test in the Reduce spec

maybe fixes #1209 (could u test @himat ?)


Closes #1209

@himat
Copy link

himat commented Jun 13, 2020

@schelmo how do I go about testing this? I made your changes to my locally installed vue-select package in my node_modules/ of my project, but the changes don't seem to show up. Do you recommend using yarn link to try the local module changes or something else?

@himat
Copy link

himat commented Jun 13, 2020

Here's what I tried, but I don't see the changes working when I import it in my project.

mkdir del/
cd del
yarn add vue-select
cd node_modules/vue-select
yarn link
<then I added a console.log in the src/components/Select.vue>

Then,

cd my-proj
yarn link vue-select

Then I ran my project, but I don't see the console.log being printed out.

@schelmo
Copy link
Contributor Author

schelmo commented Jun 13, 2020

the dist files are missing
use this in your projects package.json
"vue-select": "https://github.com/schelmo/vue-select.git#tmp-build",
then run npm install (or yarn install)

@himat
Copy link

himat commented Jun 13, 2020

Ah great! It has fixed my problem in #1209 - thanks for the speedy help!!

@github-actions
Copy link

🎉 This PR is included in version 3.10.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sagalbot
Copy link
Owner

sagalbot commented Jun 25, 2020

Thanks @schelmo, and thanks for reviewing @janwillemvd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing v-model does not sync with vue-select internal value
4 participants