Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Focusing, $el as a button #1067

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sagalbot
Copy link
Owner

@sagalbot sagalbot commented Feb 15, 2020

Updates the root $el to be a focusable button instead of a div. Allows for separating focusing of the component from opening the dropdown.

Feb-15-2020 11-32-47

Closes #1054
Closes #944
Related #872


  • swap root $el for button
  • implement button keypress handler
    • implementation should mimic native <select>
    • space should open dropdown, but not enter the character to search
    • return does nothing
    • modifier keys don't toggle the dropdown
    • up/down toggles dropdown, doesn't adjust typeahead index
    • left/right selects the next option in either direction
      • left/right doesn't loop the list, stops at first and last
  • update dropdown tests

WIP
Updates the root $el to be a focusable button instead of a div. Allows for separating focusing of the component from opening the dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyboard access: add a way to re-open without re-focusing Tabbing doesn't work correctly in Safari / IE11
1 participant