Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: autoscroll #1160

Merged
merged 4 commits into from
Apr 12, 2020
Merged

feat: autoscroll #1160

merged 4 commits into from
Apr 12, 2020

Conversation

sagalbot
Copy link
Owner

@sagalbot sagalbot commented Apr 12, 2020 •
edited
Loading

  • adds autoscroll prop to disable autoscrolling to the currently highlighted option
  • refactors pointerScroll mixin to use getBoundingClientRect

Fixes #449
Closes #1028
Closes #910

@sagalbot sagalbot added the UX label Apr 12, 2020
@sagalbot sagalbot marked this pull request as ready for review April 12, 2020 22:43
@sagalbot sagalbot merged commit 2eb3908 into master Apr 12, 2020
@sagalbot sagalbot deleted the feat/autoscroll branch April 12, 2020 22:44
@github-actions
Copy link

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mix359 mix359 mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released UX
Projects
None yet
Milestone
No milestone
1 participant
@sagalbot