Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate Ingress Annotation #91

Closed
jsw1993 opened this issue Jul 4, 2023 · 4 comments
Closed

Duplicate Ingress Annotation #91

jsw1993 opened this issue Jul 4, 2023 · 4 comments

Comments

@jsw1993
Copy link

jsw1993 commented Jul 4, 2023 •
edited
Loading

Hi.

The values file for the 2023 chart has duplicate annotations for the web ingress.

The nginx.ingress.kubernetes.io/proxy-body-size annotation is specified in the values file on line 83 and line 91

This means the chart doesn't validate for deployment using Flux. I'd suggest the one on line 91 is removed.

Flux issue referenced here: fluxcd/helm-controller#283

Many thanks
@garnold54
Copy link
Contributor

Thanks! I have submitted a fix internally. I'm going to be away on vacation until next week, but I will get that fix into this public repo when I am back and will update you here.

@jsw1993
Copy link
Author

jsw1993 commented Jul 7, 2023

Brill, many thanks.

@garnold54
Copy link
Contributor

Thanks for your patience! Version 0.2.61 of the fmeserver-2023-0 chart should have this fix in it.

@jsw1993
Copy link
Author

jsw1993 commented Jul 11, 2023

Absolute hero. Is deploying perfectly with flux. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garnold54 @jsw1993