Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3415 add owner from owner keys; GH-3416 add address to address book. #3417

Merged
merged 1 commit into from
May 27, 2024

Conversation

DmitryBespalov
Copy link
Contributor

Handles #3415.
Handles #3416.

Changes proposed in this pull request:

* Add new "owner key list updated" internal notification
* Add "owner keys" option to the "select address" screen used in the safe creation
* Add long press gesture to an addresses to create or edit address book entry (or safe name, or owner key name) (GH-3416).
@DmitryBespalov DmitryBespalov self-assigned this May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 137 lines in your changes are missing coverage. Please review.

Project coverage is 8.25%. Comparing base (2924ecd) to head (4cf664a).
Report is 1 commits behind head on main.

Files Patch % Lines
Multisig/UI/UI Library/Views/AddressInfoView.swift 0.00% 63 Missing ⚠️
... Safe/Setup Safe/SelectAddressViewController.swift 0.00% 24 Missing ⚠️
...yViewController/ChooseOwnerKeyViewController.swift 0.00% 15 Missing ⚠️
Multisig/Logic/OwnerKeyController.swift 0.00% 12 Missing ⚠️
...essBook/CreateAddressBookEntryViewController.swift 0.00% 10 Missing ⚠️
...sViewController/TransactionDetailCellBuilder.swift 0.00% 6 Missing ⚠️
...n Request/WebConnectionRequestViewController.swift 0.00% 1 Missing ⚠️
...I/Details/WebConnectionDetailsViewController.swift 0.00% 1 Missing ⚠️
...ate Safe/Setup Safe/CreateSafeViewController.swift 0.00% 1 Missing ⚠️
...uteTransaction/ReviewExecutionViewController.swift 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3417      +/-   ##
========================================
- Coverage   8.27%   8.25%   -0.03%     
========================================
  Files        788     788              
  Lines      44098   44210     +112     
========================================
  Hits        3648    3648              
- Misses     40450   40562     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit ced3b19 into main May 27, 2024
3 of 5 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-3415/add-owner-select-address branch May 27, 2024 14:14
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant