Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MFA] Your Safe Account Security Screen for MFA #3294

Open
the-real-chrizzo opened this issue Aug 14, 2023 · 1 comment
Open

[MFA] Your Safe Account Security Screen for MFA #3294

the-real-chrizzo opened this issue Aug 14, 2023 · 1 comment
Assignees

Comments

@the-real-chrizzo
Copy link
Contributor

the-real-chrizzo commented Aug 14, 2023

What needs to be done

  • Implement screen as indicated in the desigsn
  • Change colour for "Your owner recovery kit" from red (if no MFA is enabled) to green (if MFA is enabled)
  • When a user clicks on the "Your owner recovery kit" the "Set up MFA" screen appear (UI is not part of this story)
  • Change "°" to green check marks for the the 3 items in the upper part of the screen if user sets those up, i.e if recovery kit is enabled, if more owners are added, if confirmation threshold is increased

Acceptance criteria
-Designs implemented as specified above

Reference
Figma https://www.figma.com/file/Oo95065RJXyuQIFkdMQ9Cs/MFA-authentication?type=design&node-id=1450-3840&mode=design&t=yO0KS2sfAOhSpsek-4

@liliya-soroka
Copy link
Member

liliya-soroka commented Aug 29, 2023

Reopened.Please recheck implementation:

  1. Top block colours ( the top is always green)
  2. "Add owner" is not checked when there are 2 owners but policy 1 of N or even N of M
  3. recovery kit is marked as done , when it's not done
  4. "Your recovery kit" should be displayed only for the Social login keys
  5. Check "we recommend more then 1 owner" with Tanya when there are more owners
  6. Check the screen view when no owners with social login keys in the safe

Checked cases:

  1. read-only safe
  2. my safe on Polygon without social login key
  3. 1 of 1 safe with social key
  4. 1 of N safe with social key as one of the owners
  5. 2 of N safe with social key as one of the owners
  6. N of M safe without social key owner, but with diff type of key in the app
    app version 3.23.0 (1948)

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants