-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DirectX11 messes with HDR #36
Comments
Even with HDR, I remember noticing that it would record screen in 8-bit color instead of 10-bit. Maybe there's an API for DirectX that supports 10-bit. |
Are you talking about DirectX9 oder 11 mode? Wouldn't that mean that the colors sent to Hyperion are terribly wrong? They did not seem noticeably wrong to me... |
I believe in both modes, the colors are being sent as 8-bit. The API used to capture the screen in either mode return 8-bit image, even if the screen is running in HDR mode. If now they have added some APIs to capture HDR and Hyperion supports 10-bit colors, we can try to find some way to send it over, but I'm not sure about either of those. |
Hi i too have noticed all kind of weird behaviour with HDR and Hyp.Screen Cap. It seems that while HSC is running as soon as an application tries to go exclusive-full-screen said application's "handling" of the HDR metadata is overwritten and windows desktop settings kick in. to reproduce this: This only occurs in fullscreen mode though (bc. windowed/borderless uses desktop settings anyway). So it would be great if HSC supported HDR-full screen. (the only app that i found which kind of circumvents this issue for video-playback is the experimental kodi-19-matrix with hdr support if you enable "refresh rate / resolution change on playback" and have HSC running beforehand. I haven't found a workaround for games demanding full-screen mode though) |
I'm not sure if I understand the HDR metadata part. Can you please explain? |
Hi, total DX noob here but I noticed HDR colors being washed out so I came here to check if there is a solution in the works. From my research IDXGIOutput5::DuplicateOutput1 allows you to select output format including 10bit ones. I don't think Hyperion supports 10bit formats so probably the grabber would have to do some tone mapping. |
I've opened a pull request that fixes HDR mode DX11 Capture. |
When using the DirectX11 mode, it somehow discards HDR. I have non-HDR coloring (e.g. red turns to orange and everything is brighter). This does not occur in DirectX9 mode or when ScreenCap is turned off.
I am using MPC-BE with madVR to play a 4K HDR movie.
What might be the reason? I am happy to try out any suggestions.
Thanks!
The text was updated successfully, but these errors were encountered: