Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No feature test for window dimensions in testXSupport functions #48

Open
darine opened this issue May 30, 2018 · 0 comments
Open

No feature test for window dimensions in testXSupport functions #48

darine opened this issue May 30, 2018 · 0 comments

Comments

@darine
Copy link

darine commented May 30, 2018

The getViewportSize function does a comprehensive job of feature-testing how to get the pixel dimensions of the window/document. However, the testVHSupport and testVWSupport functions use window.innerHeight/innerWidth directly, and testVMinSupport uses document.documentElement.clientHeight/clientWidth directly.

The tests should probably go through getViewportSize to obtain the necessary pixel dimension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@darine