feat: s2_request_token header (exercise idempotence) #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shikhar
reviewed
Nov 28, 2024
shikhar
reviewed
Nov 28, 2024
shikhar
reviewed
Nov 29, 2024
src/service.rs
Outdated
| uuid::Uuid::new_v4() | ||
| .as_bytes() | ||
| .iter() | ||
| .fold(String::new(), |mut output, b| { |
There was a problem hiding this comment.
You could also just use the default to_string()?
There was a problem hiding this comment.
cant use to_string, as hex conversion traits are not implemented for chars
There was a problem hiding this comment.
I meant on the Uuid object, which would produce hex (with hyphens, but that's ok) https://docs.rs/uuid/latest/uuid/struct.Uuid.html#formatting
There was a problem hiding this comment.
Oh simple().to_string() would give you exactly this
shikhar
reviewed
Nov 29, 2024
shikhar
approved these changes
Nov 29, 2024
shikhar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #82