Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use if_exists for delete basin/stream #85

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

vrongmeal
Copy link
Member

This probably got removed when we shifted to using simply Status for errors which removed parse_status.

Resolves: #83

This probably got removed when we shifted to using simply `Status` for
errors which removed `parse_status`.

Resolves: #83

Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal vrongmeal requested a review from a team as a code owner November 27, 2024 20:01
@shikhar
Copy link
Member

shikhar commented Nov 27, 2024

Yes, looks like this got undone in 0d142ee!

Thanks for the fix

@shikhar shikhar merged commit 2b5ef21 into main Nov 27, 2024
3 checks passed
@shikhar shikhar deleted the vrongmeal/if-exists branch November 27, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused if_exists on DeleteBasinRequest & DeleteStreamRequest
2 participants