chore: Add expect messages instead of unwraps #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaibhav Rabber <[email protected]>
shikhar
reviewed
Nov 19, 2024
src/client.rs
Outdated
| basin_zone: basin_endpoint.map(|b| b.parse().unwrap()), | ||
| cell: cell_endpoint | ||
| .parse() | ||
| .expect("should be a valid cell endpoint"), |
There was a problem hiding this comment.
preference for more affirmative expectations, e.g. valid cell endpoint, that ideally mention why it is reasonable to have that expectation, e.g. previously validated cell endpoint
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
shikhar
reviewed
Nov 19, 2024
src/client.rs
Outdated
| .user_agent(config.user_agent.clone()) | ||
| .unwrap() | ||
| .expect("previously validated user agent") |
There was a problem hiding this comment.
the reason here is that it is literally a HeaderValue right?
There was a problem hiding this comment.
how would you prefer specifying this?
There was a problem hiding this comment.
changed it to converting HeaderValue into HeaderValue, feels much more clear
shikhar
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.