fix: Limit retries when read resumes but stream keeps erroring #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaibhav Rabber <[email protected]>
shikhar
reviewed
Nov 19, 2024
| } | ||
| if let Some(duration) = backoff.as_mut().and_then(|b| b.next()) { | ||
| sleep(duration).await; | ||
| if let Ok(new_responses) = client.send_retryable(request.clone()).await { |
There was a problem hiding this comment.
so there will be another layer of retry-with-backoff here...
There was a problem hiding this comment.
Yup, the read request happens as usual with retries. The reason I added an outer backoff as well is if the read request returns a successful response but the stream keeps on erroring.
shikhar
reviewed
Nov 19, 2024
shikhar
approved these changes
Nov 19, 2024
Signed-off-by: Vaibhav Rabber <[email protected]>
|
Updated the PR with config options for retries. |
shikhar
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.