Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow custom tonic connectors & expose more errors #54

Merged
merged 8 commits into from
Nov 12, 2024
Merged

feat: allow custom tonic connectors & expose more errors #54

merged 8 commits into from
Nov 12, 2024

Conversation

infiniteregrets
Copy link
Member

@infiniteregrets infiniteregrets commented Nov 11, 2024 •
edited
Loading

No description provided.

@infiniteregrets infiniteregrets requested a review from a team as a code owner November 11, 2024 06:22
shikhar
shikhar requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@shikhar shikhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we discussed not having it on the ClientConfig

@infiniteregrets infiniteregrets changed the title feat: allow custom tonic connectors feat: allow custom tonic connectors & expose more errors Nov 12, 2024
shikhar
shikhar reviewed Nov 12, 2024
View reviewed changes
src/client.rs Outdated Show resolved Hide resolved
@infiniteregrets infiniteregrets merged commit f1c1b15 into main Nov 12, 2024
2 checks passed
@infiniteregrets infiniteregrets deleted the connector branch November 12, 2024 20:04
@shikhar shikhar mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikhar shikhar shikhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infiniteregrets @shikhar