-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Redo endpoint logic (#39) #40
Conversation
Fixes: #39 Signed-off-by: Vaibhav Rabber <[email protected]>
I have added an example for getting endpoints from environment (like we would want to). |
As a followup, see the note about not including |
Signed-off-by: Vaibhav Rabber <[email protected]>
Made the requested changes.
Can you clarify which note? We don't send the basin header if it's part of the URI, that is handled properly I believe. Moreover, I was thinking of adding some validation on SDK side to only allow a few valid basin zones after https://github.com/s2-streamstore/s2/pull/395 since setting a basin zone implies we want to send basin name in the URI here. |
Signed-off-by: Vaibhav Rabber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed some tweaks! Feel free to merge if LGTY too. Regarding the additional validation, can be a followup?
Yup, once the server side changes are pushed. |
Fixes: #39