chore: Switch on missing_docs
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: #29 Signed-off-by: Vaibhav Rabber <[email protected]>
|
Apart from proto struct headings, I don't think anything else should be left. |
Comment on lines
+1585
to
1591
| /// Name of a basin. | ||
| /// | ||
| /// Must be between 8 and 48 characters in length. Must comprise lowercase | ||
| /// letters, numbers, and hyphens. Cannot begin or end with a hyphen. | ||
| #[derive(Debug, Clone)] | ||
| pub struct BasinName(String); | ||
|
|
There was a problem hiding this comment.
ah this duplicates with what sync_docs syncs on CreateBasinRequest
There was a problem hiding this comment.
Some duplication is inevitable I suppose. The CreateBasinRequest has:
/// Basin name, which must be globally unique. It can be omitted to let the service assign a unique name.
which is irrelevant.
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #29