Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ping (#48) #63

Merged
merged 18 commits into from
Dec 11, 2024
Merged

feat: Ping (#48) #63

merged 18 commits into from
Dec 11, 2024

Conversation

vrongmeal
Copy link
Member

@vrongmeal vrongmeal commented Dec 10, 2024

$ s2 pingtest my-basin pingtest/express -n 5
Preparing test...
ack: 28 ms    e2e: 29 ms
ack: 28 ms    e2e: 28 ms
ack: 28 ms    e2e: 28 ms
ack: 27 ms    e2e: 27 ms
ack: 28 ms    e2e: 28 ms

Sent 5 batches with 102402 bytes

-------- Append Acknowledgement Latency Statistics ---------
     Mean 28 ms
   Median 28 ms
      P95 28 ms
      P99 28 ms
      Max 28 ms
      Min 27 ms
  Std Dev 0 ms

-------------- End to End Latency Statistics ---------------
     Mean 28 ms
   Median 28 ms
      P95 29 ms
      P99 29 ms
      Max 29 ms
      Min 27 ms
  Std Dev 0 ms

Resolves: #48

Resolves: #48

Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal vrongmeal requested a review from a team as a code owner December 10, 2024 19:42
@shikhar
Copy link
Member

shikhar commented Dec 10, 2024

please factor out a new mod for as much of the new code as reasonable

@shikhar
Copy link
Member

shikhar commented Dec 11, 2024

@vrongmeal let's just call it ping :)

Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal vrongmeal changed the title feat: Pingtest (#48) feat: Ping (#48) Dec 11, 2024
@vrongmeal
Copy link
Member Author

Updated:

$ s2 ping vr-basin pingtest/express -n 5 -b 50000
Preparing...
50004 bytes:  ack = 30 ms   e2e = 32 ms
50004 bytes:  ack = 29 ms   e2e = 29 ms
49999 bytes:  ack = 28 ms   e2e = 29 ms
49992 bytes:  ack = 29 ms   e2e = 29 ms
50008 bytes:  ack = 29 ms   e2e = 29 ms

Sent 5 batches with 250007 bytes

-------- Append Acknowledgement Latency Statistics ---------
     Mean 29 ms
   Median 29 ms
      P95 30 ms
      P99 30 ms
      Max 30 ms
      Min 28 ms
  Std Dev 0 ms

-------------- End to End Latency Statistics ---------------
     Mean 29 ms
   Median 29 ms
      P95 32 ms
      P99 32 ms
      Max 32 ms
      Min 29 ms
  Std Dev 1 ms

src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/ping.rs Outdated Show resolved Hide resolved
src/ping.rs Outdated Show resolved Hide resolved
Copy link
Member

@shikhar shikhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@vrongmeal vrongmeal merged commit 3da37de into main Dec 11, 2024
2 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/pingtest branch December 11, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ping command
2 participants