-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a consistent account id for topic ARN #38
Comments
@jononu, I don't think there was a specific reason to use timestamps for ARNs, maybe you can just set static account ID, like |
@s12v sounds good, incoming PR soon. :) |
We tried out the 0.3.0 docker image this morning, that image is still generating ARNs with a timestamp. Was 0.3.0 supposed to have the change from PR #39? I logged into the container and it has an sns.jar from Nov 22nd in it rather than Dec 6th. If you haven't gotten around to pushing a new image and I'm jumping the gun just let me know. 👍 |
@jononu, no, it's not supposed to be like that. Thanks, I'll check. |
Any luck figuring it out? We're just trying to decide if we should go ahead and build a custom docker image or wait. |
@jononu, it should be fixed now, please try the new version 0.3.5. Sorry for the delay |
@jononu Can you please verify this issue was resolved with 0.3.5? |
Would you be open to accepting a PR to support this? We have some static configurations across our development team and would like the topics to be created with a consistent ARN. Right now it's using timestamp for the account id, which is obviously not consistent.
I was thinking it could pull an environment variable or fall back to the timestamp if the environment variable isn't set.
Let me know what you think.
The text was updated successfully, but these errors were encountered: