Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a consistent account id for topic ARN #38

Closed
jononu opened this issue Dec 6, 2017 · 7 comments
Closed

Use a consistent account id for topic ARN #38

jononu opened this issue Dec 6, 2017 · 7 comments

Comments

@jononu
Copy link
Contributor

jononu commented Dec 6, 2017

Would you be open to accepting a PR to support this? We have some static configurations across our development team and would like the topics to be created with a consistent ARN. Right now it's using timestamp for the account id, which is obviously not consistent.

I was thinking it could pull an environment variable or fall back to the timestamp if the environment variable isn't set.

Let me know what you think.

@s12v
Copy link
Owner

s12v commented Dec 6, 2017

@jononu, I don't think there was a specific reason to use timestamps for ARNs, maybe you can just set static account ID, like 123456789012

@jononu
Copy link
Contributor Author

jononu commented Dec 6, 2017

@s12v sounds good, incoming PR soon. :)

@jononu
Copy link
Contributor Author

jononu commented Dec 7, 2017

We tried out the 0.3.0 docker image this morning, that image is still generating ARNs with a timestamp. Was 0.3.0 supposed to have the change from PR #39?

I logged into the container and it has an sns.jar from Nov 22nd in it rather than Dec 6th.

If you haven't gotten around to pushing a new image and I'm jumping the gun just let me know. 👍

@s12v
Copy link
Owner

s12v commented Dec 7, 2017

@jononu, no, it's not supposed to be like that. Thanks, I'll check.

@jononu
Copy link
Contributor Author

jononu commented Dec 15, 2017

Any luck figuring it out? We're just trying to decide if we should go ahead and build a custom docker image or wait.

@s12v
Copy link
Owner

s12v commented Feb 15, 2018

@jononu, it should be fixed now, please try the new version 0.3.5. Sorry for the delay

@hodonsky
Copy link

@jononu Can you please verify this issue was resolved with 0.3.5?

@s12v s12v closed this as completed Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants