Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 19 #873

Open
PedroAVJ opened this issue Dec 11, 2024 · 4 comments
Open

Support React 19 #873

PedroAVJ opened this issue Dec 11, 2024 · 4 comments

Comments

@PedroAVJ
Copy link

Describe the issue and the actual behavior

When upgrading next js to version 15 I get the following warnings after running their upgrade codemod

react-number-format 5.4.2
  ├── ✕ unmet peer react@"^0.14 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0": found 19.0.0
  └── ✕ unmet peer react-dom@"^0.14 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0": found 19.0.0

Describe the expected behavior

React 19 should be listed as peer deps

@kumarSNS
Copy link

npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR! react@"^19.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^0.14 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0" from re
npm ERR! node_modules/react-number-format
npm ERR! react-number-format@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@gvillo
Copy link

gvillo commented Dec 13, 2024

this!

@SoyMarco
Copy link

I'm also interested in making it compatible with React 19 to enable migration. It's the only dependency left to migrate.

@jbigman
Copy link

jbigman commented Dec 18, 2024

PR in progress #871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants