-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This action fails in combination with Python 3.10 #169
Comments
@csadorf Thanks for reporting this bug! That said I also fiddled around with the test you try to run and it looks like it doesn't do what you expect. A workaround for the previous behavior would be to install a python 3.10 env and run the code from there So if you want to test that the dependencies can be installed on python 3.10 you need to replace setup-conda/.github/workflows/reproduce-issue-169.yml Lines 1 to 40 in bbb1fe7
And in that case, it fails due to the too strictly pinned versions. Hope these workarounds help until I got time to fix the issue. |
@all-contributors please add @csadorf for bug |
I've put up a pull request to add @csadorf! 🎉 |
@s-weigand Thank you very much for the support and also for reviewing our workflow and even proposing an improvement. 👍 Indeed, the specification of a specific Python version as part of the job you replicated has no effect and I would only want to keep it to avoid unexpected failures related to the action. However, the actual tests for checking whether the package can be installed for a specific Python version is implemented here: - name: Setup Conda
uses: s-weigand/setup-conda@v1
with:
python-version: ${{ matrix.python-version }}
update-conda: false
conda-channels: conda-forge
- run: conda --version
- run: python --version
- run: which python
- name: Test direct installation
run: |
conda create --dry-run -n test-install aiida-core python=${{ matrix.python-version }} And unless I am missing something it should work as expected.
I will implement the workaround for now, so that we can move forward. Thank you! |
This should be fixed in the v1.1.0 release. |
Describe the bug
Unable to use this step in combination with Python version "3.10".
The bug occurred as part of a workflow defined here.
To Reproduce
The following workflow definition should reproduce the problem:
Expected behavior
The action creates a conda environment with Python 3.10.
The text was updated successfully, but these errors were encountered: