Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy Queries #35

Closed
ryanwelcher opened this issue Nov 17, 2023 · 7 comments
Closed

Taxonomy Queries #35

ryanwelcher opened this issue Nov 17, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ryanwelcher
Copy link
Owner

I'd like to add some controls for querying by taxonomy. There is prior art from the meta query controls that can be leveraged here.
As MVP, I'll start with being able to use the options laid out here - https://www.whereisit5pmrightnow.com/

I have started some experiments in this branch and am seeing some odd behaviour with the include_children and operator fields so I may start with basic tax and term selection as MVP.

@ryanwelcher ryanwelcher added the enhancement New feature or request label Nov 17, 2023
@ryanwelcher ryanwelcher added this to the 2.1.0 milestone Nov 17, 2023
@ryanwelcher ryanwelcher self-assigned this Nov 17, 2023
@ryanwelcher ryanwelcher removed this from the 2.1.0 milestone Dec 29, 2023
@carstingaxion
Copy link

carstingaxion commented May 25, 2024

I'd like to add some controls for querying by taxonomy. There is prior art from the meta query controls that can be leveraged here. As MVP, I'll start with being able to use the options laid out here - https://www.whereisit5pmrightnow.com/

I have started some experiments in this branch and am seeing some odd behaviour with the include_children and operator fields so I may start with basic tax and term selection as MVP.

Exactly what I did. I took your meta-query controls and modified them to provided nice controls for taxonomy-queries.

Within my use-case - querying by context, not by hard-coded term-ids, I didn’t had big troubles with the includes property. Maybe I didn’t mention any errors or maybe it could help you going on with this issues.

Feel invited to https://github.com/carstingaxion/additional-advanced-query-loops/tree/contextual-query-loop and carstingaxion#10

@JosVelasco
Copy link

Hey, @carstingaxion and @ryanwelcher. I'd love to use the plugin to query related posts by context in a single template.

How can I test the branch for contextual queries? I activated the plugin but could not find the advanced query loop block.

@carstingaxion
Copy link

Hey, @carstingaxion and @ryanwelcher. I'd love to use the plugin to query related posts by context in a single template.

Cool @JosVelasco, that is exactly what I wanted, too and why I forked @ryanwelcher|s great work.

How can I test the branch for contextual queries? I activated the plugin but could not find the advanced query loop block.

I guess because I was a little too rigid in the beginning. Unsure how far I could get with my idea of contextual queries, I renamed everything to “Contextual query loop” to be able to run the original plugin and my fork in parallel. Try this name in the inserter.

Now, that I would like to provide a PR with my additions, I have to revert all the renaming at first. And I haven’t found the time, yet. (And tomorrow morning starts the family holiday)

So feel free to use my fork until some point in the future, where contextual queries will eventually be merged into Advanced query loop.

@JosVelasco
Copy link

Unfortunately, the block does not appear. I wonder if it has something to do with a newer WordPress version.

@carstingaxion
Copy link

Unfortunately, the block does not appear. I wonder if it has something to do with a newer WordPress version.

Fixed it.

The original plugin gitignores the /build files, why things were working for me all the time, but for nobody else (who did not do the build manually). I'm sorry.

Now it should work for you, as it works in a Playground

(funfact: In 6 hours my family & me are going to start our holiday, so we can both be lucky to have this fixed before)

Thanks for your feedback @JosVelasco !

@JosVelasco
Copy link

Happy holidays, @carstingaxion!

@ryanwelcher
Copy link
Owner Author

Closed with #90

@ryanwelcher ryanwelcher added this to the 4.0.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants