Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check: build passthru.tests when present #118

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

Ekleog
Copy link
Contributor

@Ekleog Ekleog commented Jun 11, 2019

This is my first attempt at haskell in a quite long time, and I haven't been able to nix-build the file produced by cabal2nix even before my changes (maybe due to my being on 19.03?), so it's quite possible that this does not even parse.

Other than that, I've tried to keep things consistent, and hopefully this should work!

@Ekleog Ekleog force-pushed the passthru-tests branch 2 times, most recently from 74812f8 to a8b549a Compare June 11, 2019 18:14
@Ekleog
Copy link
Contributor Author

Ekleog commented Jun 11, 2019

(Replacing <nixpkgs> with channel:nixpkgs-unstable in the shell.nix allowed me to test locally)

@Ekleog
Copy link
Contributor Author

Ekleog commented Jun 11, 2019

(all stupid errors fixed locally, travis should pass now)

@ryantm ryantm merged commit 96e5129 into nix-community:master Jun 12, 2019
@ryantm
Copy link
Collaborator

ryantm commented Jun 12, 2019

Thanks!

@ryantm
Copy link
Collaborator

ryantm commented Jun 16, 2019

NixOS/nixpkgs#63216
@Ekleog
Looks like something is going wrong because it is creating a warning for packages without tests.

@ryantm
Copy link
Collaborator

ryantm commented Jun 16, 2019

pushing /nix/store/s7j02mg1fg6nxiwy0yih5i1fscvq3sih-brial-1.2.5
All done.
mktemp -d
/tmp/tmp.VanUS1zMPa
nix-build --option sandbox true --option restrict-eval true --arg config '{ allowBroken = true; allowUnfree = true; allowAliases = false; }' -E '{ config }: (
import ./. { inherit config; }).brial.tests or {}'
error: access to path '/tmp/tmp.VanUS1zMPa' is forbidden in restricted mode

@Ekleog
Copy link
Contributor Author

Ekleog commented Jun 16, 2019

@ryantm I've submitted a tentative fix in #119 :)

FRidh added a commit to FRidh/nixpkgs that referenced this pull request Feb 6, 2020
ofborg does not build them yet, but at least nixpkgs-update does.
nix-community/nixpkgs-update#118
Note this test passes and would not have detected
NixOS#79304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants