New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: JSX "DetailsHtmlAttributes" missing "name" attribute #381

Open

mihail-semyonov opened this issue Nov 10, 2024 · 1 comment

mihail-semyonov commented Nov 10, 2024

Hey, I'm getting following typescript error when using name attribute on details html element:

Type '{ children: Element[]; name: string; }' is not assignable to type 'DetailsHtmlAttributes<HTMLDetailsElement>'.
  Property 'name' does not exist on type 'DetailsHtmlAttributes<HTMLDetailsElement>'.

<details name="test">
  <summary>Test</summary>
  <div>Content</div>
</details>

According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#name details element can have name attribute

The text was updated successfully, but these errors were encountered:

Contributor

titoBouzout commented Nov 11, 2024

There's a PR that besides some other unrelated stuff it also adds that attributes #380
reviews welcome!

titoBouzout mentioned this issue

update types #380

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment