Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

th as a child of a component results in The HTML provided is malformed #358

Open
katywings opened this issue Sep 27, 2024 · 4 comments
Open

Comments

@katywings
Copy link

katywings commented Sep 27, 2024

Is

Rendering a <th> in a <Show>, <For> or basically any component results in "The HTML provided is malformed and will yield unexpected output when evaluated by a browser." warnings.

<Show when={true}>
  <th class="one"></th>
</Show>
<Parent>
  <th class="two"></th>
</Parent>

Should

This should not result in a warning.

Repro

https://stackblitz.com/edit/github-wixnng?file=src%2Froutes%2Findex.tsx
(check the Terminal)

Refs

#350

@titoBouzout
Copy link
Contributor

@katywings I have just seen this! Yeah, validation for th was missing, my bad. There was also a need to cover the outer bits which I didn't consider, such empty table/thead/tbody.
I think all should be covered in #360

@katywings
Copy link
Author

@titoBouzout Haha all good :). I am looking forward to the PR, the warnings are a bit spammy during hmr development 😂

@jorbuedo
Copy link

@titoBouzout I think caption is missing as well.

@titoBouzout
Copy link
Contributor

@titoBouzout I think caption is missing as well.

Thanks for the report! Its interesting I do not think I have ever used any of these tags, I have added caption and took the opportunity to refactor it a little #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants