Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizing dom-expressions #356

Open
titoBouzout opened this issue Sep 25, 2024 · 0 comments
Open

Modernizing dom-expressions #356

titoBouzout opened this issue Sep 25, 2024 · 0 comments

Comments

@titoBouzout
Copy link
Contributor

I have been having some issues with the require vs imports stuff. I would appreciate an update to dom-expressions that modernizes it in a way that import just works out of the box.

I know dom-expressions version 2 it's in our thoughts, but before that happens I suggest a modernization, to allow us keep contributing without friction.

Just to illustrate the problem, I had trouble to add tests for functions that expect import in one place, but the same function expect require in the test case (or reversed, the environment changes in someway). I cannot reuse the function without duplicating it to a new place, which means it will require updates whenever any of the two functions change. So I didn't add the tests, and that's not cool.

I am asking, but I don't know what are the implications or required effort to get into such a shape, so please do not take me wrong. If it is doable, take this post as pushing kindly to it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant