Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for light/dark themes #3

Open
ryanjwessel opened this issue May 1, 2020 · 0 comments
Open

Add support for light/dark themes #3

ryanjwessel opened this issue May 1, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ryanjwessel
Copy link
Owner

It would be nice to be able to switch between the current Material Palenight-inspired theme and a light-theme.

The functionality would look similar to Dan Abramov's personal blog: Overreacted.

This effort would involve fixing global theming. The createGlobalStyle API from the styled-components library caused issues on my last attempt at integrating it, so I replaced it with a plain CSS file. This is problematic because I cannot maintain theme constants between CSS and JS files.

This Issue would involve one of the following:

  1. Updating the styled-components implementation to handle global styles with Next.js's server-side rendering
  2. Using a different approach
@ryanjwessel ryanjwessel added the enhancement New feature or request label May 1, 2020
@ryanjwessel ryanjwessel self-assigned this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant