-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audio_service breaks some app links when used with the app_links package [android] #1108
Comments
This issue does not follow the issue template. If you click the "New issue" button, it should require you to answer a number of different questions. |
Hmm, I'll have to look into that. |
My template chooser config file looks correct so I'm not sure what happened. Maybe it's a GitHub fault... Anyway, the link is here: https://ryanheise.github.io/audio_service/issue-form/issue.html You can use it to create a new issue with all the required information in it. When you click Submit, it will take you back to GitHub where all details you entered are formatted in a GitHub issue. At this point, you can either submit that issue to GitHub or you can copy and paste the formatted issue text from there into THIS issue to avoid creating multiple issues. You can also edit your initial post above to include the required information. |
Thanks for letting me know @ryanheise ! I've updated the issue now. |
Hi @ryanheise - hope I'm not bothering you, just want to make sure that you saw the updated issue. Let me know if there's any issues with reproducing the bug. I appreciate all the work you put into this plugin. If you have any background info on what audio_service does regarding deep linking, that'd help me with investigating the issue further too. Thank you! |
I did, I have just been busy catching up with things after having the flu for 3 weeks, so I am slowly working my way to this. |
Thanks for letting me know! Sorry, didn't mean to pressure you. Happy to hear you're doing better again! |
Documented behaviour
Not documented.
Actual behaviour
I use the app_links package to make it so links to my website (regular https links, not deep links with a custom scheme) get opened inside the webview of the app.
Most of the time the app links work completely fine, but we noticed that when a user is at checkout and tries to log in with a magic link (login link sent via e-mail), the webview breaks (becomes either unresponsive or blank).
This is related to audio_service because the issue no longer appears when I don't inherit from AudioServiceFragmentActivity. Normally I have
but when I use
the bug no longer occurs.
Runtime error
Minimal reproduction project
https://github.com/Aulig/audio_service_wv_bug
Reproduction steps
These are modified (from a regular use case) instructions so you don't have to register for an account, so they might seem a bit weird.
Do once:
Do every time you want to reproduce the error:
Here's a video: https://e.pcloud.link/publink/show?code=XZbyylZqnAsfBy84BL31XKAdgzQm8QxnPxV
Sorry that the steps to reproduce are so complicated, I wasn't able to simplify them further yet because I don't understand how audio_service interacts with deep linking.
Output of flutter doctor
Devices exhibiting the bug
Google Pixel 3a Android 12
The text was updated successfully, but these errors were encountered: