Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hard-coded limitations in API's to configurable #9

Open
4 tasks
ryanRfox opened this issue Apr 2, 2018 · 0 comments
Open
4 tasks

Change hard-coded limitations in API's to configurable #9

ryanRfox opened this issue Apr 2, 2018 · 0 comments
Labels
1a Epic High level concept to be addressed. Description may contain a list referencing child User Stories 2g Accepted Alerts the team that the solution passes the test cases and is ready for implementation 3b Feature Add additional functionality to design 6 API
Milestone
FUTURE: Feature R...

Comments

@ryanRfox
Copy link
Owner

ryanRfox commented Apr 2, 2018 •
edited
Loading

Change those FC_ASSERT( limit <= 100 ) limitations to configurable. Inspired by bitshares#781 (comment).

  • change them to configurable
  • add API to fetch the configured values (Server Info API #10)
  • add restricted API for service providers to change the values on the fly (without restarting the server)
    • maybe remember changed value. Not easy since we're using (almost) read-only config.ini and startup parameters right now.
@ryanRfox ryanRfox added 6 API 3b Feature Add additional functionality to design 2d Developing Covers refining requirement definition, design and development 1b User Story User story/requirement detailing referenced parent high level Requirement. May reference Task(s) labels Apr 2, 2018
@ryanRfox ryanRfox added this to the FUTURE: Feature Release milestone Apr 2, 2018
@ryanRfox ryanRfox added 1a Epic High level concept to be addressed. Description may contain a list referencing child User Stories and removed 1b User Story User story/requirement detailing referenced parent high level Requirement. May reference Task(s) labels Apr 2, 2018
@ryanRfox ryanRfox added 2g Accepted Alerts the team that the solution passes the test cases and is ready for implementation and removed 2d Developing Covers refining requirement definition, design and development labels May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1a Epic High level concept to be addressed. Description may contain a list referencing child User Stories 2g Accepted Alerts the team that the solution passes the test cases and is ready for implementation 3b Feature Add additional functionality to design 6 API
Projects
None yet
Milestone
FUTURE: Feature Release
Development

No branches or pull requests
1 participant
@ryanRfox