-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement sum helper as strict alias for add helper #614
implement sum helper as strict alias for add helper #614
Conversation
a437c49
to
63cbe31
Compare
Hi, @skeate back to your #40 (comment)
I did a bit confused in fact that the documentation for the addon |
@@ -0,0 +1 @@ | |||
export { default, sum } from 'ember-math-helpers/helpers/sum'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mifrill I think we could just export from add here and be good to go. Something like this maybe?
export { default, sum } from 'ember-math-helpers/helpers/sum'; | |
export { default, add as sum } from 'ember-math-helpers/helpers/add'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwwagner90 well, in this way file addon/helpers/sum.js
will came redundant, right? So, then we would need to customize documentation somehow that provided by ember-cli-addon-docs
because comments in file addon/helpers/sum.js
have auto-converts into the component with documentation.
However, the original proposal is to have the documented sum
helper:
maybe it's better to keep it consistent with the documentation addon with no this requested change, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwwagner90 could you give an advice on how to customize documentation for this particular case?
7fc503b
to
63cbe31
Compare
closes #40