Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'oidc_provider' Header (remove underscore) #161

Open
fxjordan opened this issue Sep 26, 2022 · 0 comments
Open

Rename 'oidc_provider' Header (remove underscore) #161

fxjordan opened this issue Sep 26, 2022 · 0 comments

Comments

@fxjordan
Copy link

The oidc_provider header contains an underscore. This seems to be allowed in HTTP, but so uncommon that Nginx needs a special configuration flag to allow for headers containing an underscore (https://dev.to/thesameeric/dont-use-underscores-in-your-http-headers-gfp).

In a recent bug, this caused a lot of extra work for me while find out why the OIDC provider was not set correctly. Sometimes, developers may even not know that a Nginx reverse proxy is running in front of their las2peer application and get strange behavior. Also, they might not be able to change the Nginx configuration in some cases.

Therefore, I'm proposing to rename the header to oidc-provider. The old header name can still be parsed for legacy reasons while we introduce the new header name.

public static final String OIDC_PROVIDER_KEY = "oidc_provider";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant