Generate FromUriParam<Query> impls for some Option types #1420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue when trying to create next/prev page links while reusing existing optional parameters, something like
cc #998 (comment), it allows forms
a
andb
for the added typesI tried creating a blanket impl for
Option<T>
, however that conflicts with theT -> Option<T>
forwarding, so instead generate them for individual types using a macroOption<&str>
,Option<&RawStr>
andOption<Cow<str>>
are not included because they also generated conflicts with existing impls