Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failures in Nightly due to Proc macro API 1.2 changes #646

Closed
tirkarthi opened this issue May 21, 2018 · 9 comments
Closed

Build failures in Nightly due to Proc macro API 1.2 changes #646

tirkarthi opened this issue May 21, 2018 · 9 comments
Labels
nightly breakage Breakage on the nightly channel only

Comments

@tirkarthi
Copy link

Bug report :

Project fails with Nightly compiler due to the recent proc macro API changes made that renames some of the components. It seems the release of proc macros 2 library with the changes already merged will fix the issue. I searched for issues here and couldn't find anything related to this. Hence I am opening this as a reminder to upgrade dependency. Feel free to close this if it's tracked elsewhere or irrelevant.

Upstream rustc issue reference : rust-lang/rust#50473 (comment)
Upstream proc macros 2 PR (merged) : dtolnay/proc-macro2#90
Build failure : https://travis-ci.org/SergioBenitez/Rocket/jobs/381529609

Thanks for the library.

@tirkarthi
Copy link
Author

0.4.3 released with the changes. Ref : https://github.com/alexcrichton/proc-macro2/tree/0.4.3

@jebrosen
Copy link
Collaborator

quote 0.6 and syn 0.14 were just released 9 hours ago, so this should be possible to fix now. @SergioBenitez have you started work on this migration or would a PR be helpful?

@SergioBenitez
Copy link
Member

@jebrosen I would love a PR here. The changes necessary should be minimal.

@SergioBenitez
Copy link
Member

Fixed in 00dd691.

@SergioBenitez SergioBenitez added the nightly breakage Breakage on the nightly channel only label May 29, 2018
@tsathishkumar
Copy link

Will there be a new version of Rocket with build fixes?

@jebrosen
Copy link
Collaborator

@tsathishkumar: This issue was only in the master branch of Rocket, which has now been fixed.

@tsathishkumar
Copy link

@jebrosen I'm using rocket version 0.3.11 in my code and the build is failing. So I was wondering if there will be a new version coming out soon. Thanks for the response.

@jebrosen
Copy link
Collaborator

@tsathishkumar if a cargo update does not resolve the build failures, please file a new issue with more details.

@tsathishkumar
Copy link

The issue still persists, because 0.3.11 was built before your fix. I'm going to temporarily point to git branch and build my project and wait for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nightly breakage Breakage on the nightly channel only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants