Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support upgrading of old token format. #29

Open
bcomnes opened this issue Jul 15, 2021 · 2 comments
Open

Support upgrading of old token format. #29

bcomnes opened this issue Jul 15, 2021 · 2 comments

Comments

@bcomnes
Copy link
Collaborator

bcomnes commented Jul 15, 2021

OK, so github just made us go through an entire rewrite of device flow auth, and then decided to change their token formats.

Now I get an email whenever someone uses my app with an old token 😭

Would it be alright to support transparent token upgrades when an old token is discovered?

https://docs.github.com/en/rest/reference/apps#reset-a-token

(I could implement maybe).

@rvagg
Copy link
Owner

rvagg commented Jul 16, 2021

oh joy

I guess transparent upgrades won't be a terrible thing since we're already taking care of the whole creation process anyway. Maybe just print to the console when it's happening though (stderr probably).

Thanks for staying on top of this @bcomnes

@bcomnes
Copy link
Collaborator Author

bcomnes commented Jul 16, 2021

I might be able to invalidate all app tokens as well at a per app level. A bit ham fisted, but that could work too. Ill look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants