Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-bindgen dependency in Cargo.toml is out of date in chapter-zero #33

Open
reillysiemens opened this issue Aug 22, 2018 · 3 comments

Comments

@reillysiemens
Copy link

Describe the bug
Without an update of the wasm-bindgen dependency from v0.2.13 to v0.2.17 the initial npm run build-debug on the chapter-zero branch fails to compile.

To Reproduce
Steps to reproduce the behavior:

  1. git clone https://github.com/rustwasm/wasm_game_of_life.git
  2. cd wasm_game_of_life
  3. git checkout -b chapter-zero origin/chapter-zero
  4. npm install
  5. npm run build-debug

Expected behavior
npm run build-debug compiles without error.

Screenshots
npm-run-build-debug-error

Additional context
It's no trouble to run cargo update -p wasm-bindgen, but I think that slows readers down. Luckily the error messages are very clear, but it might still be intimidating to a newcomer to troubleshoot this.

For what it's worth, I'm using

  • nvm - v0.33.11
  • Node.js - v10.9.0
  • npm - v6.4.0
  • cargo - 1.29.0-nightly (6a7672ef5 2018-08-14)
  • wasm-bindgen-cli - v0.2.17
@reillysiemens reillysiemens changed the title wasm-bindgen dependency in Cargo.toml is out of date wasm-bindgen dependency in Cargo.toml is out of date in chapter-zero Aug 22, 2018
@mgattozzi
Copy link
Contributor

Hey @reillysiemens to avoid this we should put 0.2 as the dep for wasm-bindgen in the Cargo.toml that way it always uses the newest version and not include a Cargo.lock. Can you confirm this works for the code as is today?

@reillysiemens
Copy link
Author

Yeah, it looks like that'll work just fine, @mgattozzi. I'd be happy to submit that as a fix if you like. 😁
removing-cargo-lock-works

@JOE1994
Copy link

JOE1994 commented Apr 29, 2020

Since Cargo.toml in the master branch specifies the wasm-bindgen dependency to be 0.2,
this issue is resolved in the master branch and can now be closed 👍
The project still builds and runs successfully as of today (04/29/2020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants