Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support WebIDL modules #1746

Closed
wants to merge 4 commits into from
Closed

WIP: Support WebIDL modules #1746

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 29, 2019

Fixes #1740 (eventually); adds support for WebIDL modules.

Related: rustwasm/weedle#31

@alexcrichton
Copy link
Contributor

Looking reasonable to me! Could you expand a bit on the expected impact of web-sys as well?

@ghost
Copy link
Author

ghost commented Sep 4, 2019

@alexcrichton thanks! I will open a companion PR for weedle in a bit.

Regarding the expected impact on web-sys, I haven't thought too much about that yet. The goal is that code generation for webidls that don't use modules should remain unchanged. There should be opportunities to benefit from supporting modules going forward though.

The main motivation for this right now is to bring more flexibility for writing webidls for things like electron and node and other larger libraries that are difficult to fully cover with wasm-bindgen-cli and not currently possible to model accurately with wasm-bindgen-webidl.

If y'all have thoughts about how this might impact web-sys or other parts of the ecosystem, I'd be interested to here more about that.

@alexcrichton
Copy link
Contributor

Ok cool sounds good, I mostly just wanted to double check that this doesn't change much of the current APIs. For generating new ones it might be neat to generate a literal Rust module for a WebIDL module perhaps? That coupled with the unstable attributes I think should be sufficient here

@ghost
Copy link
Author

ghost commented Oct 20, 2019

I'm going to close this since I've put the parser rewrite on hold to focus on other things I'm not sure if/when I'll be able to get back to it. I still think it would be a good idea to support webidl module syntax at some point. Thanks for the feedback!

@ghost ghost closed this Oct 20, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for WebIDL modules?
2 participants