web-sys function bindings should be generic over AsRef<T> instead of &T

[bgourlie]

Take the definition of append_child for example.

pub fn append_child(&self, node: &Node) -> Result<Node, JsValue>

I find myself having to manually coerce an Element into the correct type, for example:

let document = web_sys::window().unwrap().document().unwrap();
let val = document.create_element("p").unwrap();
val.set_inner_html("Hello from Rust, WebAssembly, WebPack, and web-sys!");
AsRef::<Node>::as_ref(&document.body().unwrap()).append_child(AsRef::<Node>::as_ref(&val));

[Pauan]

I think it's unlikely that the web-sys crate will use AsRef generics, since it's supposed to be a direct 1-to-1 translation of WebIDL.

However, there is an RFC proposal which will solve this problem (it uses Deref, not AsRef). That means that this code will work just fine:

document.body().unwrap().append_child(&val);

No AsRef needed!

[bgourlie]

Oh, perfect! Thanks for the heads up!