Update WebIDL to use undefined instead of void
#2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grovesNL
commented
Jan 20, 2021
crates/webidl/Cargo.toml
Outdated
| @@ -21,7 +21,7 @@ proc-macro2 = "1.0" | |||
| quote = '1.0' | |||
| syn = { version = '1.0', features = ['full'] } | |||
| wasm-bindgen-backend = { version = "=0.2.69", path = "../backend" } | |||
| weedle = "0.11" | |||
| weedle = { git = "https://github.com/rustwasm/weedle" } | |||
There was a problem hiding this comment.
We'll need to use a published version here, so this PR can wait for that
| @@ -503,6 +503,10 @@ impl<'src> FirstPass<'src, (&'src str, ApiStability)> for weedle::interface::Int | |||
| log::warn!("Unsupported WebIDL Setlike interface member: {:?}", self); | |||
| Ok(()) | |||
| } | |||
| InterfaceMember::AsyncIterable(_iterable) => { | |||
There was a problem hiding this comment.
This is unrelated to undefined/void changes, it's just a new variant added between weedle 0.11 and weedle master also noticed in #2373 (comment)
grovesNL
force-pushed
the
void-undefined
branch
from
520a6cc
to
77a0ec7
Compare
|
Looks great to me, thanks! I think the only thing this needs now is a weedle publish, right? |
|
Yeah I think we just need to publish a new version of weedle and use it here, which will also unblock progress in #2373. Created a PR at rustwasm/weedle#44 |
|
Ok published! |
grovesNL
force-pushed
the
void-undefined
branch
from
77a0ec7
to
721bd1f
Compare
|
Thanks! This should be ready now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated weedle to use
undefinedinstead ofvoidin rustwasm/weedle#43, so now the plan is to update all WebIDL too.The changes here are split into two commits for reviewing. The first commit updates all of the WebIDL and the second commit updates how the tokens are used from weedle.
Overall the changes seem to be fine because the generated bindings don't show any differences.