Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested namespace not working in 0.2.63 #2169

Closed
ctaggart opened this issue May 29, 2020 · 1 comment
Closed

nested namespace not working in 0.2.63 #2169

ctaggart opened this issue May 29, 2020 · 1 comment
Labels

Comments

@ctaggart
Copy link
Contributor

Describe the Bug

I'm getting an error when trying to use #2105. cc @hajifkd.

^CCamerons-MacBook-Pro:monaco-hello-world cameron$ cargo build
    Blocking waiting for file lock on build directory
   Compiling monaco-hello-world v0.1.0 (/Users/cameron/rs/ts2rs/monaco-hello-world)
error: expected an identifier
  --> monaco-hello-world/src/lib.rs:17:58
   |
17 |         #[wasm_bindgen(module = "monaco", js_namespace = ["monaco", "editor"])]

I've got 0.2.63 of wasm-bindgen installed.

Camerons-MacBook-Pro:monaco-hello-world cameron$ cargo tree
monaco-hello-world v0.1.0 (/Users/cameron/rs/ts2rs/monaco-hello-world)
├── js-sys v0.3.40
│   └── wasm-bindgen v0.2.63
│       ├── cfg-if v0.1.10
│       └── wasm-bindgen-macro v0.2.63
│           ├── quote v1.0.6
│           │   └── proc-macro2 v1.0.17
│           │       └── unicode-xid v0.2.0
│           └── wasm-bindgen-macro-support v0.2.63
│               ├── proc-macro2 v1.0.17 (*)
│               ├── quote v1.0.6 (*)
│               ├── syn v1.0.27
│               │   ├── proc-macro2 v1.0.17 (*)
│               │   ├── quote v1.0.6 (*)
│               │   └── unicode-xid v0.2.0
│               ├── wasm-bindgen-backend v0.2.63
│               │   ├── bumpalo v3.3.0
│               │   ├── lazy_static v1.4.0
│               │   ├── log v0.4.8
│               │   │   └── cfg-if v0.1.10
│               │   ├── proc-macro2 v1.0.17 (*)
│               │   ├── quote v1.0.6 (*)
│               │   ├── syn v1.0.27 (*)
│               │   └── wasm-bindgen-shared v0.2.63
│               └── wasm-bindgen-shared v0.2.63
├── wasm-bindgen v0.2.63 (*)
└── web-sys v0.3.40
    ├── js-sys v0.3.40 (*)
    └── wasm-bindgen v0.2.63 (*)
Camerons-MacBook-Pro:monaco-hello-world cameron$ cargo --version
cargo 1.45.0-nightly (9fcb8c1d2 2020-05-25)
cargo install --list

wasm-bindgen-cli v0.2.63:
    wasm-bindgen
    wasm-bindgen-test-runner
    wasm2es6js
wasm-pack v0.9.1:
    wasm-pack

Steps to Reproduce

The bug can be reproduce on this line.

git clone [email protected]:taggartsoftware/ts2rs.git
git checkout monaco-hello-world

Uncomment the wasm-bindgen section in lib.rs, then cargo build.

@ctaggart
Copy link
Contributor Author

Because it is not in 0.2.63. Really looking forward to 0.2.64!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant