Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump semantic version for additions to Instr or tag it #[non_exhaustive] #274

Closed
dfoxfranke opened this issue Sep 25, 2024 · 1 comment · Fixed by #276
Closed

Bump semantic version for additions to Instr or tag it #[non_exhaustive] #274

dfoxfranke opened this issue Sep 25, 2024 · 1 comment · Fixed by #276
Labels
bug Something isn't working

Comments

@dfoxfranke
Copy link

The 0.21.2 release of walrus broke semantic versioning by adding ReturnCall and ReturnCallIndirect variants to the Instr enum. Either this enum should be tagged as #[non_exhaustive], or additions to it should be a semantic version bump.
@dfoxfranke dfoxfranke added the bug Something isn't working label Sep 25, 2024
@guybedford guybedford mentioned this issue Sep 25, 2024
Merged
@guybedford
Copy link
Collaborator

I've published a 0.21.3 with that fix thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add non_exhaustive to Instr enum rustwasm/walrus
2 participants
@guybedford @dfoxfranke