Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ferris component #43

Open
jdonszelmann opened this issue Jan 30, 2025 · 2 comments
Open

Ferris component #43

jdonszelmann opened this issue Jan 30, 2025 · 2 comments

Comments

@jdonszelmann
Copy link
Contributor

@grafische-republiek

> .ferris,
> .ferris-arms {
@include wider_than(sm) {
background-repeat: no-repeat;
background-size: contain;
height: 120px;
position: absolute;
rotate: 90deg;
width: 144px;
}
@include wider_than(xl) {
height: 240px;
width: 288px;
}
}
> .ferris {
@include wider_than(sm) {
background-image: url("/images/ferris.png");
/* This timing is for the leaving animation */
transition: translate 300ms ease-out;
translate: -24px;
}
}
> .ferris-arms {
@include wider_than(sm) {
background-image: url("/images/ferris-arms.png");
background-position: center -12px;
/* This timing is for the leaving animation */
transition:
opacity 200ms 300ms ease-out,
translate 200ms 200ms ease-out;
translate: 10px;
opacity: 0;
z-index: 1;
clip-path: circle(34%);
}
}
}
}

this css is duplicated several times

> .ferris,
> .ferris-arms {
@include wider_than(sm) {
background-repeat: no-repeat;
background-size: contain;
height: 120px;
position: absolute;
rotate: 90deg;
width: 144px;
}
@include wider_than(xl) {
height: 240px;
width: 288px;
}
}
> .ferris {
@include wider_than(sm) {
background-image: url("/images/ferris.png");
/* This timing is for the leaving animation */
transition: translate 300ms ease-out;
translate: -24px;
}
}
> .ferris-arms {
@include wider_than(sm) {
background-image: url("/images/ferris-arms.png");
background-position: center -12px;
/* This timing is for the leaving animation */
transition:
opacity 200ms 300ms ease-out,
translate 200ms 200ms ease-out;
translate: 10px;
opacity: 0;
z-index: 1;
clip-path: circle(34%);
}
}
}
}

idk why we didn't spot it in review but that should be a component

@jdonszelmann
Copy link
Contributor Author

otherwise it becomes hard to maintain

@erikjee
Copy link
Contributor

erikjee commented Jan 30, 2025

@jdonszelmann this was not @grafische-republiek but Mara and me just copying things. I asked @tertsdiepraam to re-work this at the time (not just the ferris part, but the full location component). That got lost somewhere, I guess.
Can one of you two do it, you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants